Milan/cache attempt 2 #1911
Draft
Milan/cache attempt 2 #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MellowYarker
force-pushed
the
milan/cache-attempt-2
branch
13 times, most recently
from
4eaf8b0
to
6afab2f
Compare
Reading actor cache isn't easy, and if things are immutable then we should convey that in the code.
This allows us to mutate from UNKNOWN to PRESENT or ABSENT but permit no other transition.
MellowYarker
force-pushed
the
milan/cache-attempt-2
branch
from
6afab2f
to
b0e4e9a
Compare
This commit introduces `addToCleanList()` and `addToDirtyList()` to make it obvious when we're actually transitioning between lists.
This helps make it a bit more obvious that we don't want to touch `syncStatus` directly.
This commit does a few notable things: - Counted deletes now use the lastFlush promise instead of their own fulfillers. This does mean that counted delete promises will resolve later in some rare cases like a counted delete and a delete all being requested within the same scheduled flush or a counted delete being issued as part of a transaction. The goal here is to get to a point where *all* operations just have to wait for the flush promise after they are scheduled. - Counted deletes now maintain their own list of participating entries (somewhat like delete all). This means that we no longer have to "inherit" counted deletes when entries are overridden or do iterator tracking when building their flush batches.
MellowYarker
force-pushed
the
milan/cache-attempt-2
branch
2 times, most recently
from
55709ed
to
f8ee87b
Compare
Makes removeEntry() the only way we remove from lists. Adds/corrects some comments
This commit attempts to provide a mechanism to cancel the promise that waits for the read batches to complete in syncGets(). This is needed for when the `ActorCache` is destroyed, since we need to destroy all `Entry`s before we destroy the `SharedLru`.
MellowYarker
force-pushed
the
milan/cache-attempt-2
branch
from
f8ee87b
to
5f385ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempting to salvage what we can from the actor cache PR 馃檭