Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various cleanups. #19

Merged
merged 3 commits into from Sep 25, 2022
Merged

Various cleanups. #19

merged 3 commits into from Sep 25, 2022

Commits on Sep 25, 2022

  1. Various comment cleanups. 

    I was just skimming code and fixed things.
    @kentonv
    kentonv committed Sep 25, 2022
    Configuration menu
    Copy the full SHA
    7013c51 View commit details
    Browse the repository at this point in the history

  2. Move jaeger-model.proto to live next to jaeger.{h,c++,capnp}. 

    It was awkward having this file just sitting in `src` as it is very visible there, but this is actually dead code in `workerd`, so it's a weird thing to call attention to.
    @kentonv
    kentonv committed Sep 25, 2022
    Configuration menu
    Copy the full SHA
    1d14a4e View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary copy constructor definition for CryptoKeyUsageSet. 

    This explicit definition matched what the implicit copy constructor would do, but declaring it led to a compiler warning due to not having the corresponding copy assignment operator. I decided to delete the constructor and let it become defaulted rather than add assignment separately.
    @kentonv
    kentonv committed Sep 25, 2022
    Configuration menu
    Copy the full SHA
    a083cc0 View commit details
    Browse the repository at this point in the history