New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

D1 API: Re-attempting changes to .run behind a compat_date flag #1890

Draft

geelen wants to merge 1 commit into main from glen/d1-run-compat-date

Collaborator

geelen commented Mar 25, 2024

This PR will need:

D1 api to use compat_date to determine which resultsFormat to send
D1 mock & production API can be restored to honour resultsFormat = NONE
Types updated for pre/post compat_date, to show that .run() won't return results after a certain date.


          Changing tests to reflect current D1 behaviour

515ef76

Which is that `resultsFormat=NONE` is still being sent but being ignored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment