Fix websocket auto-response message races #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jqmmes
force-pushed
the
joaquim/ws-autoresponse-segfault-fix
branch
4 times, most recently
from
65863fb
to
8a5c005
Compare
bcaimano
reviewed
Oct 16, 2023
jqmmes
force-pushed
the
joaquim/ws-autoresponse-segfault-fix
branch
2 times, most recently
from
813a381
to
41f4b54
Compare
bcaimano
approved these changes
Oct 16, 2023
jqmmes
force-pushed
the
joaquim/ws-autoresponse-segfault-fix
branch
from
41f4b54
to
efc8ac0
Compare
This PR fixes racing issues between regular websocket messages and auto-responses.
jqmmes
force-pushed
the
joaquim/ws-autoresponse-segfault-fix
branch
from
efc8ac0
to
c08ad41
Compare
|
Thank you, @bcaimano and @MellowYarker for the very fast review! |
This was
linked to
issues
Oct 17, 2023
MellowYarker
approved these changes
Oct 17, 2023
jqmmes
force-pushed
the
joaquim/ws-autoresponse-segfault-fix
branch
from
c08ad41
to
6053b8e
Compare
|
Thanks for the cleanup! |
jasnell
reviewed
Oct 17, 2023
Co-authored-by: James M Snell <jsnell@cloudflare.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes racing issues between regular websocket messages and auto-responses.
The initial version of this PR held a jsg::Ref<> for a long time, which could cause occasional segfaults. This new version fixes that segfault.