adding created() event to IsolateObserver (#90)

cloudflare · Oct 11, 2022 · 4aa91a7 · 4aa91a7
1 parent 988b242
commit 4aa91a7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/workerd/io/observer.h b/src/workerd/io/observer.h
@@ -74,6 +74,9 @@ class RequestObserver: public kj::Refcounted {
 
 class IsolateObserver: public kj::AtomicRefcounted {
 public:
+  virtual void created(kj::StringPtr id) {};
+  // Called when Worker::Isolate is created.
+
   virtual void evicted() {}
   // Called when the owning Worker::Script is being destroyed. The IsolateObserver may
   // live a while longer to handle deferred proxy requests.

diff --git a/src/workerd/io/worker.c++ b/src/workerd/io/worker.c++
@@ -977,6 +977,7 @@ Worker::Isolate::Isolate(kj::Own<ApiIsolate> apiIsolateParam,
       metrics(kj::mv(metricsParam)),
       impl(kj::heap<Impl>(*apiIsolate, *metrics, *limitEnforcer, allowInspector)),
       weakIsolateRef(kj::atomicRefcounted<WeakIsolateRef>(this)) {
+  metrics->created(id);
   // We just created our isolate, so we don't need to use Isolate::Impl::Lock (nor an async lock).
   auto lock = apiIsolate->lock();
   auto features = apiIsolate->getFeatureFlags();