Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/cloudflare_list_item: retry list ID fetches #3303

Merged
merged 1 commit into from
May 13, 2024

Conversation

jacobbednarz
Copy link
Member

Updates the functionality used for fetching the individual list item identifiers to include a retry should the result not be an exact match.

This should handle the situations better where a large batch operation is created and takes some time behind the scenes to complete the polling operation.

Closes #3269

Updates the functionality used for fetching the individual list item
identifiers to include a retry should the result not be an exact match.

This should handle the situations better where a large batch operation
is created and takes some time behind the scenes to complete the
polling operation.

Closes #3269
Copy link
Contributor

changelog detected ✅

@jacobbednarz
Copy link
Member Author

acceptance tests all passing

TF_ACC=1 go test ./internal/framework/service/list_item -v -run "^TestAccCloudflareListItem_" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareListItem_Basic
=== PAUSE TestAccCloudflareListItem_Basic
=== RUN   TestAccCloudflareListItem_MultipleItems
--- PASS: TestAccCloudflareListItem_MultipleItems (19.60s)
=== RUN   TestAccCloudflareListItem_Update
--- PASS: TestAccCloudflareListItem_Update (24.46s)
=== RUN   TestAccCloudflareListItem_BadListItemType
--- PASS: TestAccCloudflareListItem_BadListItemType (5.30s)
=== RUN   TestAccCloudflareListItem_ASN
--- PASS: TestAccCloudflareListItem_ASN (12.92s)
=== RUN   TestAccCloudflareListItem_Hostname
--- PASS: TestAccCloudflareListItem_Hostname (13.75s)
=== RUN   TestAccCloudflareListItem_Redirect
--- PASS: TestAccCloudflareListItem_Redirect (14.19s)
=== CONT  TestAccCloudflareListItem_Basic
--- PASS: TestAccCloudflareListItem_Basic (15.50s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/list_item	107.085s

@jacobbednarz jacobbednarz merged commit ef58111 into master May 13, 2024
9 of 10 checks passed
@jacobbednarz jacobbednarz deleted the apply-retry-to-list-items branch May 13, 2024 04:41
@github-actions github-actions bot added this to the v4.33.0 milestone May 13, 2024
github-actions bot pushed a commit that referenced this pull request May 13, 2024
Copy link
Contributor

This functionality has been released in v4.33.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error for cloudflare_list_item when same hostname but different path
1 participant