Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages updates #2083

Merged
merged 13 commits into from Jan 10, 2023
Merged

Pages updates #2083

merged 13 commits into from Jan 10, 2023

Conversation

Cyb3r-Jak3
Copy link
Contributor

Updates cloudflare_pages_project resource to fix changing for cloudflare/cloudflare-go#1136. Opening as draft as the acceptance tests are failing for secrets.

=== RUN   TestAccCloudflarePagesProject_DeploymentConfig
    resource_cloudflare_pages_project_test.go:238: Step 1/1 error: After applying this test step and performing a `terraform refresh`, the plan was not empty.
        stdout
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # cloudflare_pages_project.rparovllfn will be updated in-place
          ~ resource "cloudflare_pages_project" "rparovllfn" {
                id                = "rparovllfn"
                name              = "rparovllfn"
                # (5 unchanged attributes hidden)
        
              ~ deployment_configs {
                  ~ preview {
                        # (10 unchanged attributes hidden)
        
                      - secret {
                          - name = "SECRET" -> null
                        }
                      + secret {
                          + name = "SECRET"
                          + text = (sensitive value)
                        }
        
                        # (1 unchanged block hidden)
                    }
        
                  ~ production {
                        # (10 unchanged attributes hidden)
        
                      - secret {
                          - name = "SECRET1" -> null
                        }
                      + secret {
                          + name = "SECRET1"
                          + text = (sensitive value)
                        }
                      - secret {
                          - name = "SECRET2" -> null
                        }
                      + secret {
                          + name = "SECRET2"
                          + text = (sensitive value)
                        }
        
                        # (1 unchanged block hidden)
                    }
                }
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccCloudflarePagesProject_DeploymentConfig (6.21s)
``

@github-actions
Copy link
Contributor

changelog detected ✅

@github-actions
Copy link
Contributor

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@Cyb3r-Jak3
Copy link
Contributor Author

Marking ready to review. I've decided to handle the secrets part at a later time.

@Cyb3r-Jak3 Cyb3r-Jak3 marked this pull request as ready for review January 7, 2023 18:35
.changelog/2083.txt Outdated Show resolved Hide resolved
.changelog/2083.txt Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit ceb3fe8 into cloudflare:master Jan 10, 2023
@github-actions github-actions bot added this to the v3.32.0 milestone Jan 10, 2023
github-actions bot pushed a commit that referenced this pull request Jan 10, 2023
@Cyb3r-Jak3 Cyb3r-Jak3 deleted the pages-updates branch January 10, 2023 22:00
@github-actions
Copy link
Contributor

This functionality has been released in v3.32.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants