Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for job.Filter before validation #1704

Closed
wants to merge 5 commits into from
Closed

Add check for job.Filter before validation #1704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f10a716
Add check for job.Filter before validation
sawp-d Jun 15, 2022
327dbe5
Create 1704.txt in changelog
sawp-d Jun 15, 2022
af82cc5
Get filter from resource data to check for nil
sawp-d Jun 16, 2022
dcb8275
Update .changelog/1704.txt
sawp-d Jun 16, 2022
352eeb0
Update after running gofmt
sawp-d Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/1704.txt
View file
Open in desktop
@@ -0,0 +1,3 @@
```release-note:bug
resource/cloudflare_logpush_job: fix null `filter` attribute throwing parsing error
```
2 changes: 1 addition & 1 deletion internal/provider/resource_cloudflare_logpush_job.go
View file
Open in desktop
Expand Up @@ -118,7 +118,7 @@ func resourceCloudflareLogpushJobRead(ctx context.Context, d *schema.ResourceDat
return nil
}

if job.Filter.Where.Validate() == nil {
if job.Filter.Where.Validate() == nil && d.Get("filter") != nil {
filterstr, err := json.Marshal(job.Filter)
if err != nil {
return diag.FromErr(err)
Expand Down