Waitingroom event bugfix

[broswen]

• Set ID on waiting room event expansion.
  cloudflare-go uses the id in the struct to create the path for the API request so it must be set. (https://github.com/cloudflare/cloudflare-go/blob/master/waiting_room.go#L342)
• Propagating changes to use time pointer for PrequeueStartTime. (add next_event_prequeue_start_time and next_event_start_time  cloudflare-go#878)

[github-actions]

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

[jacobbednarz]

this is going to error in the Create where it is referenced as d.SetId() isn't called until after the API calls are made and this value doesn't exist.

[broswen]

Makes sense, I'll just extract from the ResourceData and set it manually.

[jacobbednarz]

is there a test case we should be adding for this as well?

[broswen]

is there a test case we should be adding for this as well?

Before this change, we would see prequeue_start_time set to the default time.Time value (epoch start). Now it should not be set (null).
Is there a terraform test function we can use to compare a state drift? Before the change we would see that prequeue_start_time would be set even though the terraform config doesn't have it set.
I would think that resource.TestCheckNoResourceAttr(name, "prequeue_start_time"), should have caught this but I'm not sure why it didn't.

[broswen]

The latest commit should get that TestCheck working. Since it wasn't using a pointer before it was comparing to the zero value and would not set if it was a zero value (epoch start).

[jacobbednarz]

acceptance tests are passing

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareWaitingRoomEvent_" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareWaitingRoomEvent_Create
=== PAUSE TestAccCloudflareWaitingRoomEvent_Create
=== CONT  TestAccCloudflareWaitingRoomEvent_Create
--- PASS: TestAccCloudflareWaitingRoomEvent_Create (16.79s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/provider	17.360s
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]

[github-actions]

This functionality has been released in v3.16.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!