Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH-4232 add saas app remove bookmark specific app resource #1647

Conversation

AkemiDavisson
Copy link
Contributor

@AkemiDavisson AkemiDavisson commented May 26, 2022

Depends on: cloudflare/cloudflare-go#900 before merge

@github-actions
Copy link
Contributor

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

@jacobbednarz jacobbednarz added the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label May 29, 2022
@jacobbednarz
Copy link
Member

thanks for this @AkemiDavisson! as this is removing a resource causing a breaking change, we need to leave the cleanup until the next major release and support this until we get there. in the meantime, we can deprecate the resource by updating the method calls to emit a diag.Warn about the deprecation and include a callout in the documentation to make sure people don't keep using this resource.

i've added this to track via #1646.

@jacobbednarz jacobbednarz mentioned this pull request May 31, 2022
38 tasks
@AkemiDavisson AkemiDavisson force-pushed the akemi/AUTH-4232_appTypeImprovements branch from d781aa5 to 26a689c Compare June 6, 2022 21:32
@jacobbednarz jacobbednarz removed the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label Jun 8, 2022
@github-actions
Copy link
Contributor

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@github-actions
Copy link
Contributor

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants