Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/cloudflare_access_application: fix inability to update http_only_cookie_attribute to false #1619

Merged
merged 10 commits into from May 25, 2022
Merged

resource/cloudflare_access_application: fix inability to update http_only_cookie_attribute to false #1619

merged 10 commits into from May 25, 2022

Conversation

Justin-Holmes
Copy link
Contributor

@Justin-Holmes Justin-Holmes commented May 11, 2022 •
edited

Requires a new version of cloudflare-go with cloudflare/cloudflare-go#880 before this can be merged.

Closes #1561

@github-actions
Copy link
Contributor

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

@Justin-Holmes Justin-Holmes changed the title Fix inability to update http_only_cookie_attribute to false resource/cloudflare_access_application: fix inability to update http_only_cookie_attribute to false May 11, 2022
jacobbednarz
jacobbednarz reviewed May 12, 2022
View reviewed changes
Copy link
Member

@jacobbednarz jacobbednarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nitpicks but looks good!

cloudflare/resource_cloudflare_access_application.go Outdated Show resolved Hide resolved
.changelog/1602.txt Outdated Show resolved Hide resolved
Justin-Holmes and others added 5 commits May 16, 2022 09:03
@Justin-Holmes @jacobbednarz
Update cloudflare/resource_cloudflare_access_application.go
4ff5bbc 
Co-authored-by: Jacob Bednarz <jacob.bednarz@hey.com>
@Justin-Holmes @jacobbednarz
Update .changelog/1602.txt
0673150 
Co-authored-by: Jacob Bednarz <jacob.bednarz@hey.com>
@jacobbednarz
cleanup Bool/BoolPtr usage
e51bb75
@jacobbednarz
use the specific notFoundErr for missing checks
2f677a3
@jacobbednarz
fix tests for access apps
0d4ee32 
Updates the access application tests to fix a couple of niggly issues.

- Don't check both account and zone access applications; we only need to do one or the other.
- Check for explicit `cloudflare.NotFoundError` errors when checking the resource still exists.
- Remove left over usage of API token clear/reset now the service supports it.
@jacobbednarz
Copy link
Member

acceptance tests are all passing

TF_ACC=1 go test $(go list ./...) -v -run "^TestAccCloudflareAccessApplication_" -count 1 -parallel 1 -timeout 120m -parallel 1
?   	github.com/cloudflare/terraform-provider-cloudflare	[no test files]
=== RUN   TestAccCloudflareAccessApplication_BasicZone
--- PASS: TestAccCloudflareAccessApplication_BasicZone (15.19s)
=== RUN   TestAccCloudflareAccessApplication_BasicAccount
--- PASS: TestAccCloudflareAccessApplication_BasicAccount (14.21s)
=== RUN   TestAccCloudflareAccessApplication_WithCORS
--- PASS: TestAccCloudflareAccessApplication_WithCORS (14.06s)
=== RUN   TestAccCloudflareAccessApplication_WithAutoRedirectToIdentity
--- PASS: TestAccCloudflareAccessApplication_WithAutoRedirectToIdentity (13.77s)
=== RUN   TestAccCloudflareAccessApplication_WithEnableBindingCookie
--- PASS: TestAccCloudflareAccessApplication_WithEnableBindingCookie (14.44s)
=== RUN   TestAccCloudflareAccessApplication_WithCustomDenyFields
--- PASS: TestAccCloudflareAccessApplication_WithCustomDenyFields (14.21s)
=== RUN   TestAccCloudflareAccessApplication_WithADefinedIdps
--- PASS: TestAccCloudflareAccessApplication_WithADefinedIdps (19.44s)
=== RUN   TestAccCloudflareAccessApplication_WithHttpOnlyCookieAttribute
--- PASS: TestAccCloudflareAccessApplication_WithHttpOnlyCookieAttribute (13.88s)
=== RUN   TestAccCloudflareAccessApplication_WithHTTPOnlyCookieAttributeSetToFalse
--- PASS: TestAccCloudflareAccessApplication_WithHTTPOnlyCookieAttributeSetToFalse (15.19s)
=== RUN   TestAccCloudflareAccessApplication_WithSameSiteCookieAttribute
--- PASS: TestAccCloudflareAccessApplication_WithSameSiteCookieAttribute (13.85s)
=== RUN   TestAccCloudflareAccessApplication_WithLogoURL
--- PASS: TestAccCloudflareAccessApplication_WithLogoURL (13.94s)
=== RUN   TestAccCloudflareAccessApplication_WithSkipInterstitial
--- PASS: TestAccCloudflareAccessApplication_WithSkipInterstitial (13.95s)
=== RUN   TestAccCloudflareAccessApplication_WithAppLauncherVisible
--- PASS: TestAccCloudflareAccessApplication_WithAppLauncherVisible (14.01s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	190.657s
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/changelog-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/maintainer-only-file-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/tools/cmd/tf-log-check	[no test files]
?   	github.com/cloudflare/terraform-provider-cloudflare/version	[no test files]

@jacobbednarz jacobbednarz added the workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library. label May 19, 2022
@jacobbednarz jacobbednarz changed the base branch from master to dependabot/go_modules/github.com/cloudflare/cloudflare-go-0.40.0 May 25, 2022 04:45
@jacobbednarz jacobbednarz changed the base branch from dependabot/go_modules/github.com/cloudflare/cloudflare-go-0.40.0 to master May 25, 2022 04:46
@jacobbednarz jacobbednarz merged commit 050bd0a into cloudflare:master May 25, 2022
@github-actions github-actions bot added this to the v3.16.0 milestone May 25, 2022
@Justin-Holmes Justin-Holmes deleted the jholmes/http-only-bug-fix branch May 26, 2022 12:14
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

This functionality has been released in v3.16.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobbednarz jacobbednarz jacobbednarz left review comments

Assignees
No one assigned
Labels
workflow/pending-upstream-library Indicates an issue or PR requires changes from an upstream library.
Projects
None yet
Milestone
v3.16.0
Development

Successfully merging this pull request may close these issues.

cloudflare_access_application not idempotent with http_only_cookie_attribute attribute to false
2 participants
@Justin-Holmes @jacobbednarz