Fix lint

cloudflare · Jul 11, 2022 · 76b30a7 · 76b30a7
1 parent 75d9a2c
commit 76b30a7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/internal/provider/resource_cloudflare_access_application.go b/internal/provider/resource_cloudflare_access_application.go
@@ -65,10 +65,7 @@ func resourceCloudflareAccessApplicationCreate(ctx context.Context, d *schema.Re
 	}
 
 	if _, ok := d.GetOk("saas_app"); ok {
-		saasApp, err := convertSaasSchemaToStruct(d)
-		if err != nil {
-			return diag.FromErr(err)
-		}
+		saasApp := convertSaasSchemaToStruct(d)
 		newAccessApplication.SaasApplication = saasApp
 	}
 
@@ -190,10 +187,7 @@ func resourceCloudflareAccessApplicationUpdate(ctx context.Context, d *schema.Re
 	}
 
 	if _, ok := d.GetOk("saas_app"); ok {
-		saasConfig, err := convertSaasSchemaToStruct(d)
-		if err != nil {
-			return diag.FromErr(err)
-		}
+		saasConfig := convertSaasSchemaToStruct(d)
 		updatedAccessApplication.SaasApplication = saasConfig
 	}
 

diff --git a/internal/provider/schema_cloudflare_access_application.go b/internal/provider/schema_cloudflare_access_application.go
@@ -286,15 +286,15 @@ func convertCORSStructToSchema(d *schema.ResourceData, headers *cloudflare.Acces
 	return []interface{}{m}
 }
 
-func convertSaasSchemaToStruct(d *schema.ResourceData) (*cloudflare.SaasApplication, error) {
+func convertSaasSchemaToStruct(d *schema.ResourceData) *cloudflare.SaasApplication {
 	SaasConfig := cloudflare.SaasApplication{}
 	if _, ok := d.GetOk("saas_app"); ok {
 		SaasConfig.SPEntityID = d.Get("saas_app.0.sp_entity_id").(string)
 		SaasConfig.ConsumerServiceUrl = d.Get("saas_app.0.consumer_service_url").(string)
 		SaasConfig.NameIDFormat = d.Get("saas_app.0.name_id_format").(string)
 	}
 
-	return &SaasConfig, nil
+	return &SaasConfig
 }
 
 func convertSaasStructToSchema(d *schema.ResourceData, app *cloudflare.SaasApplication) []interface{} {