feat: Output Source Selection #25
Open
+52
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you for the PR @kxzazz! |
|
Thanks for the contribution, @kxzazz! I think we've got some other non-trivial work to do in order to make this work reliably (for instance, when an audio output device is disconnected), so I'm going to hold off on merging this PR for now. Once we've got the other pieces in place, we can use this to add the UI though! |
|
Thanks for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option to select the audio output device in the dialog.
Changelog
Closes #19
Added
AudioOutputSelectorin theSettingsDialogScreenshots
Before:
After: