Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable R2 persist in shared-test-environment #414

Merged
merged 1 commit into from Oct 27, 2022

Conversation

hanford
Copy link
Contributor

@hanford hanford commented Oct 19, 2022

This fixes a bug where currently shared-test-environment throws an exception when miniflare#r2_persit = true

I've run into this in the reproduction below

https://github.com/hanford/miniflare-shared-test-environment

Without this change the reproduction yields:

Screen Shot 2022-10-19 at 3 16 44 PM

With this change miniflare doesn't throw an exception and my tests pass as expected

Screen Shot 2022-10-19 at 3 17 19 PM

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2022

⚠️ No Changeset found

Latest commit: e58efae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hanford hanford changed the title Disable R2 persist in shared-test-environment Disable R2 persist in shared-test-environment Oct 19, 2022
Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 😃 Thanks for the PR!

@mrbbot mrbbot merged commit 1a21f6b into cloudflare:master Oct 27, 2022
@hanford hanford deleted the patch-1 branch October 27, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants