Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R2 bug fix: remove quotes in onlyIf headers #403

Merged
merged 4 commits into from Oct 27, 2022
Merged

R2 bug fix: remove quotes in onlyIf headers #403

merged 4 commits into from Oct 27, 2022

Conversation

CraigglesO
Copy link
Contributor

resolves #402

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2022 •
edited

⚠️ No Changeset found

Latest commit: 3904e0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CraigglesO CraigglesO changed the title remove quotes in onlyIf headers R2 bug fix: remove quotes in onlyIf headers Oct 3, 2022
mrbbot
mrbbot reviewed Oct 10, 2022
View reviewed changes
Copy link
Contributor

@mrbbot mrbbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! 👋 Thanks for fixing this! 🙂 Added a few comments.

packages/r2/src/r2Object.ts Outdated Show resolved Hide resolved
packages/r2/src/r2Object.ts Outdated Show resolved Hide resolved
packages/r2/test/r2Object.spec.ts Outdated Show resolved Hide resolved
@mrbbot mrbbot merged commit 102409c into cloudflare:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbbot mrbbot mrbbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

R2: when parsing etags, quotes should be stripped
2 participants
@CraigglesO @mrbbot