fix: bump undici version #288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbbot
added a commit
to gonzaloriestra/miniflare
that referenced
this pull request
Jun 19, 2022
Co-authored-by: Cherry <james@jross.me>
|
Closing in favour of #286. I've incorporated you're removal of the header filtering hack though. 馃檪 |
mrbbot
added a commit
that referenced
this pull request
Jun 19, 2022
* Upgrade undici to 5.5.1 * Remove header filtering hack, ref #288 Co-authored-by: MrBBot <me@mrbbot.dev> Co-authored-by: Cherry <james@jross.me>
mrbbot
pushed a commit
that referenced
this pull request
Jun 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps
undicito5.5.1which resolves GHSA-pgw7-wx7w-2w33. This doesn't impact miniflare directly, but gets rid of the scary "vulnerabilities" warning when installing.In doing this,
undicino longer does header filtering, which means the massive hack that was overriding its constants can now be removed! 馃帀See nodejs/undici#1469 for more info.