Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R2: when parsing etags, quotes should be stripped #402

Closed
vincentbernat opened this issue Oct 3, 2022 · 0 comments · Fixed by #403
Closed

R2: when parsing etags, quotes should be stripped #402

vincentbernat opened this issue Oct 3, 2022 · 0 comments · Fixed by #403

Comments

@vincentbernat
Copy link

Hey!

At

miniflare/packages/r2/src/r2Object.ts

Line 173 in 932b537

export function parseOnlyIf(
, parseOnlyIf should strip quotes from provided etags. HTTP etags are quoted, but S3/R2 etags are not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
workers-sdk
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

R2 bug fix: remove quotes in onlyIf headers CraigglesO/miniflare
2 participants
@vincentbernat @mrbbot