Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

Allow configurable downgrade of ETag validator strength #315

Merged
merged 1 commit into from Dec 9, 2022

Conversation

awwong1
Copy link
Contributor

@awwong1 awwong1 commented May 2, 2022

This PR allows users to override the default strong ETag validator behaviour to use weak ETag validators.

I was encountering issues where my worker's returned strong ETags were automatically converted to weak ETags by Cloudflare. This change allows the developer to use weak ETags and preserve 304 responses (e.g. on *.workers.dev domains).

The alternative to this is specifying page rules to preserve strong ETags (possibly enterprise only)

  • Change has unit tests
  • Readme has been updated with documentation and usage
  • This is a backwards compatible change
  • I have tested this on my own Cloudflare workers

#311

@awwong1 awwong1 requested a review from a team as a code owner May 2, 2022 17:32
@awwong1
Copy link
Contributor Author

awwong1 commented May 4, 2022

Are there any additional steps you need me to do before this PR can be accepted?
CC: @codewithkristian

@Cherry Cherry merged commit 1b7fccd into cloudflare:main Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants