Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DS-12153 support custom fields for logging #890

Merged
merged 1 commit into from May 18, 2022

Conversation

nuggien
Copy link

@nuggien nuggien commented May 18, 2022

Description

This adds support for custom fields logging to the action parameters field of the ruleset api.

Has your change been tested?

This has been tested against an updated version of the cloudflare terraform provider.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@cmackenzie1
Copy link
Contributor

LGTM.

@jacobbednarz jacobbednarz merged commit 0def37b into cloudflare:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants