AS-8430: Update history API to accept timestamp query params #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyakvs
force-pushed
the
priya/AS-8430/update-history-api-to-accept-timestamp
branch
from
37a97e7
to
56ad0f3
Compare
|
i pushed up a change in 19c9713 that swaps to using go-querystring (already in the package) for building and sending the URI parameters to save us manually doing it. do you want to do some quick tests locally with it and confirm it works as you'd expect before we merge this? |
jacobbednarz
force-pushed
the
priya/AS-8430/update-history-api-to-accept-timestamp
branch
from
19c9713
to
7d7b436
Compare
|
all good! i got this working locally using your test and confirmed it on a test account. thanks for the PR 🌟 |
|
Thanks a lot for updating this PR @jacobbednarz . Will keep this in mind for all future work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alert history API now have the ability to query by timestamp filter. This PR is to add that functionality to cloudflare-go integration as well.