s/api.AccountID/accountID #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates all methods that were relying on `api.AccountID` via the client constructor to pass in explicit account IDs for the methods instead. Closes cloudflare#694
jacobbednarz
force-pushed
the
swap-out-api-account-for-explicit-value
branch
from
54f6b8f
to
7da278b
Compare
jacobbednarz
added a commit
to jacobbednarz/cloudflare-go
that referenced
this pull request
May 16, 2022
Only workers relies on this now so we can deprecate it in favour of explicit account identifiers. Cleans up tests that never actually needed this. Follows on from cloudflare#850
Merged
jacobbednarz
added a commit
to jacobbednarz/cloudflare-go
that referenced
this pull request
May 16, 2022
Only workers relies on this now so we can deprecate it in favour of explicit account identifiers. Cleans up tests that never actually needed this. Follows on from cloudflare#850
|
@jacobbednarz Question: how about the Lines 147 to 149 in 9af8b92 |
|
yep, that eventually needs to be removed but i've left it in place as we can change it now but i'm not too worried if it hangs around for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all methods that were relying on
api.AccountIDvia the clientconstructor to pass in explicit account IDs for the methods instead.
Even though the Workers APIs still use
api.AccountID, I'm leaving themas the whole thing needs an overhaul now that the API has settled.
Closes #694