Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SaaS Access Application configuration #717

Closed
wants to merge 1 commit into from
Closed

Add support for SaaS Access Application configuration #717

wants to merge 1 commit into from

Conversation

ouranos
Copy link

@ouranos ouranos commented Oct 1, 2021

Description

Add support for SaaS Access Application configuration.

Not sure if this is supported by the API as this is not publicly documented but I tested manual calls with curl and this is working. So I'm not sure if it's an outdated documentation or an unsupported API call.

This would be handy to add support for SaaS App configuration in the terraform provider: cloudflare/terraform-provider-cloudflare#1226

Has your change been tested?

  • Added a unit test.
  • Tested the raw JSON query manually.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@jacobbednarz
Copy link
Member

Thanks but I'm unable to merge this until there is public API support (as outlined in the PR requirements). We don't add undocumented endpoints as the API isn't considered stable or supported externally.

@ouranos
Copy link
Author

ouranos commented Oct 1, 2021

Thanks but I'm unable to merge this until there is public API support (as outlined in the PR requirements). We don't add undocumented endpoints as the API isn't considered stable or supported externally.

Understood. Do you have any internal timeline for when this will be supported?

We need to create a large number of applications and I'd rather not do it manually (and would like to have it in our IaaC repo).
I might manually script it for now and import them to terraform when it is supported.

@jacobbednarz
Copy link
Member

Afraid not. The Access team is pretty on top of their API changes so there will be a reason why it's not there. You're welcome to submit a support ticket and it will be routed to the internal service team.

By all means, build and use your own version of the provider in the meantime (see the README and docs directory for how); we just won't be merging it here until the API is marked as stable.

@ouranos
Copy link
Author

ouranos commented Oct 5, 2021

Afraid not. The Access team is pretty on top of their API changes so there will be a reason why it's not there. You're welcome to submit a support ticket and it will be routed to the internal service team.

Ok, will do.

By all means, build and use your own version of the provider in the meantime (see the README and docs directory for how); we just won't be merging it here until the API is marked as stable.

Thanks, I got it working now. If/When it's supported, I'll have the code ready.

@ouranos
Copy link
Author

ouranos commented Dec 29, 2021

Hey @jacobbednarz, I saw that the documentation now has the following for type:

valid values: self_hosted, saas, ssh, vnc, file

However, the SaasApp block is still not documented so it's not yet usable.

I see that bookmark is not listed but #756 was merged.

I'll follow up on my support ticket to fix the documentation so we can hopefully merge this soon. I've just rebased.

@ouranos
Copy link
Author

ouranos commented Jul 8, 2022

@jacobbednarz Looks like this is covered by #900.

I'll clean up our local fork and prepare a PR for the terraform provider now that the SDK support it.

@ouranos ouranos closed this Jul 8, 2022
@ouranos ouranos deleted the add-support-for-saas-app branch March 14, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants