add support for client_certificate_v2 posture rule #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
jacobbednarz
reviewed
Apr 8, 2024
| State string `json:"state,omitempty"` | ||
| LastSeen string `json:"last_seen,omitempty"` | ||
| ExtendedKeyUsage []string `json:"extended_key_usage,omitempty"` | ||
| CheckPrivateKey bool `json:"check_private_key,omitempty"` |
There was a problem hiding this comment.
you'll want this to be a *bool - see https://github.com/cloudflare/cloudflare-go/blob/master/docs/conventions.md#booleans
|
feel free to ping me once the API docs are out and we'll get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added fields to DevicePostureRuleInput to accommodate needed inputs for the new posture type client_certificate_v2
This requires the merge and deployment of documentation changes found here: WDAPI-1954
Has your change been tested?
Because it is just adding fields to the DevicePostureRuleInput struct, this should not affect existing uses of it. There has been a test created to test the creation of the client_certificate_v2 posture rule to test out the added fields.
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.