Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Certificate Transparency Monitoring API #1559

Closed
wants to merge 1 commit into from

Conversation

blackknight467
Copy link

@blackknight467 blackknight467 commented Mar 14, 2024

Description

adds support for Certificate Transparency Monitoring to SDK

cloudflare terraform provider issue
cloudflare community post
cloudflare docs

Has your change been tested?

sorta, open to suggestions on how to improve

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/cloudflare-go/blob/master/docs/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included, please add the workflow/skip-changelog-entry label.

@jacobbednarz
Copy link
Member

thanks for the PR here! however, as this doesn't have API schemas defined, we won't be able to merge this since the public API contract hasn't been established. i'll label this for now and raise it with the internal service team to look into.

@blackknight467
Copy link
Author

great thanks!

@jacobbednarz
Copy link
Member

closing this out since v2 will handle this automatically once the schemas are added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants