Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom hostname status filters #1435

Conversation

adampurser-zendesk
Copy link
Contributor

@adampurser-zendesk adampurser-zendesk commented Nov 6, 2023

Description

Added the following filters for GET custom hostnames:

  • hostname_status
  • ssl_status

These filters can be used to Identify custom hostnames in certain error states. They are not publicly documented.

Has your change been tested?

Added basic unit tests.

Screenshots

image

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@adampurser-zendesk adampurser-zendesk force-pushed the adampurser-zendesk/add-custom-hostname-status-filters branch from e3bdbcd to 143ef50 Compare November 6, 2023 17:14
@adampurser-zendesk adampurser-zendesk changed the title [WIP] Add custom_hostnames status filters Add custom_hostnames status filters Nov 6, 2023
Copy link
Contributor

github-actions bot commented Nov 6, 2023

changelog detected ✅

@jacobbednarz
Copy link
Member

it doesn't look like we have this documented in our API schemas. i'll mark this as pending until those docs land (i'll poke the internal team now but no guarantee on when/if they will land).

- Filter by `hostname_status`
- Filter by `ssl_status`
@adampurser-zendesk adampurser-zendesk force-pushed the adampurser-zendesk/add-custom-hostname-status-filters branch from 143ef50 to d8fe799 Compare November 8, 2023 11:38
@adampurser-zendesk adampurser-zendesk changed the title Add custom_hostnames status filters Add support for custom hostname status filters Nov 8, 2023
@jacobbednarz
Copy link
Member

closing this out as once the API schema supports this, v2 will automatically get support for it. looks like ssl (whether or not SSL is enabled) is already there but status is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants