Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new mTLS certificate store API #1150

Merged

Conversation

vasilzhigilei
Copy link
Contributor

Description

Adding mTLS cert store API endpoints to cloudflare-go in order to add mTLS cert store to Cloudflare terraform.

Has your change been tested?

Added tests for API responses.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@gitguardian
Copy link

gitguardian bot commented Dec 21, 2022

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic Private Key 02e5fb1 mtls_certificates_test.go View secret
- Generic Private Key 06a1da1 mtls_certificates_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2022

changelog detected ✅

@codecov-commenter
Copy link

Codecov Report

Merging #1150 (54b0448) into master (4ddb00c) will decrease coverage by 0.57%.
The diff coverage is 54.63%.

@@            Coverage Diff             @@
##           master    #1150      +/-   ##
==========================================
- Coverage   50.11%   49.53%   -0.58%     
==========================================
  Files         121      127       +6     
  Lines       11722    12137     +415     
==========================================
+ Hits         5874     6012     +138     
- Misses       4565     4758     +193     
- Partials     1283     1367      +84     
Impacted Files Coverage Δ
device_posture_rule.go 61.80% <ø> (ø)
errors.go 40.78% <ø> (ø)
pages_deployment.go 34.24% <ø> (-0.24%) ⬇️
pages_domain.go 71.27% <ø> (ø)
pages_project.go 50.81% <ø> (ø)
rulesets.go 35.09% <ø> (ø)
workers_account_settings.go 29.41% <0.00%> (-6.31%) ⬇️
workers_tail.go 52.00% <ø> (ø)
workers_secrets.go 29.41% <28.00%> (-16.05%) ⬇️
workers_cron_triggers.go 29.41% <29.41%> (-16.05%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mtls_certificates.go Outdated Show resolved Hide resolved
@jacobbednarz jacobbednarz merged commit df35d94 into cloudflare:master Dec 28, 2022
@github-actions github-actions bot added this to the v0.58.0 milestone Dec 28, 2022
github-actions bot pushed a commit that referenced this pull request Dec 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

This functionality has been released in v0.58.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

ivan-section-io pushed a commit to section/cloudflare-go that referenced this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants