Skip to content

Commit

Permalink
Merge pull request #920 from mapped/fix-vnet-crud
Browse files Browse the repository at this point in the history
Fix Tunnel Virtual Network params:
  • Loading branch information
jacobbednarz committed Jun 3, 2022
2 parents f668d5b + 567edc5 commit 6df9e0b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions tunnel_virtual_networks.go
Expand Up @@ -35,15 +35,15 @@ type TunnelVirtualNetworksListParams struct {

type TunnelVirtualNetworkCreateParams struct {
AccountID string `json:"-"`
VnetName string `json:"vnet_name"`
Name string `json:"name"`
Comment string `json:"comment,omitempty"`
IsDefault *bool `json:"is_default,omitempty"`
IsDefault bool `json:"is_default"`
}

type TunnelVirtualNetworkUpdateParams struct {
AccountID string `json:"-"`
VnetID string `json:"-"`
VnetName string `json:"vnet_name,omitempty"`
Name string `json:"name,omitempty"`
Comment string `json:"comment,omitempty"`
IsDefaultNetwork *bool `json:"is_default_network,omitempty"`
}
Expand Down Expand Up @@ -97,7 +97,7 @@ func (api *API) CreateTunnelVirtualNetwork(ctx context.Context, params TunnelVir
return TunnelVirtualNetwork{}, ErrMissingAccountID
}

if params.VnetName == "" {
if params.Name == "" {
return TunnelVirtualNetwork{}, ErrMissingVnetName
}

Expand Down
6 changes: 3 additions & 3 deletions tunnel_virtual_networks_test.go
Expand Up @@ -94,8 +94,8 @@ func TestCreateTunnelVirtualNetwork(t *testing.T) {

tunnel, err := client.CreateTunnelVirtualNetwork(context.Background(), TunnelVirtualNetworkCreateParams{
AccountID: testAccountID,
VnetName: "us-east-1-vpc",
IsDefault: BoolPtr(true),
Name: "us-east-1-vpc",
IsDefault: true,
Comment: "Staging VPC for data science",
})

Expand Down Expand Up @@ -147,7 +147,7 @@ func TestUpdateTunnelVirtualNetwork(t *testing.T) {
tunnel, err := client.UpdateTunnelVirtualNetwork(context.Background(), TunnelVirtualNetworkUpdateParams{
AccountID: testAccountID,
VnetID: "f70ff985-a4ef-4643-bbbc-4a0ed4fc8415",
VnetName: "us-east-1-vpc",
Name: "us-east-1-vpc",
IsDefaultNetwork: BoolPtr(true),
Comment: "Staging VPC for data science",
})
Expand Down

0 comments on commit 6df9e0b

Please sign in to comment.