Merge pull request #1135 from WalshyDev/walshy/remove-logs-v1

Remove Pages logs v1

.changelog/1135.txt

@@ -0,0 +1,3 @@
+```release-note:note
+pages: removed the v1 logs endpoint for Pages deployments. Please switch to v2: https://developers.cloudflare.com/api/operations/pages-deployment-get-deployment-logs
+```

pages_deployment.go

@@ -181,46 +181,7 @@ func (api *API) GetPagesDeploymentInfo(ctx context.Context, rc *ResourceContaine
 	return r.Result, nil
 }
 
-// GetPagesDeploymentStageLogs returns the logs for a Pages deployment stage.
-//
-// API reference: https://api.cloudflare.com/#pages-deployment-get-deployment-stage-logs
-//
-// Deprecated: Use GetPagesDeploymentLogs instead.
-func (api *API) GetPagesDeploymentStageLogs(ctx context.Context, rc *ResourceContainer, params GetPagesDeploymentStageLogsParams) (PagesDeploymentStageLogs, error) {
-	if rc.Identifier == "" {
-		return PagesDeploymentStageLogs{}, ErrMissingAccountID
-	}
-
-	if params.ProjectName == "" {
-		return PagesDeploymentStageLogs{}, ErrMissingProjectName
-	}
-
-	if params.DeploymentID == "" {
-		return PagesDeploymentStageLogs{}, ErrMissingDeploymentID
-	}
-
-	if params.StageName == "" {
-		return PagesDeploymentStageLogs{}, ErrMissingStageName
-	}
-
-	uri := buildURI(
-		fmt.Sprintf("/accounts/%s/pages/projects/%s/deployments/%s/history/%s/logs", rc.Identifier, params.ProjectName, params.DeploymentID, params.StageName),
-		params.SizeOptions,
-	)
-
-	res, err := api.makeRequestContext(ctx, http.MethodGet, uri, nil)
-	if err != nil {
-		return PagesDeploymentStageLogs{}, err
-	}
-	var r pagesDeploymentStageLogsResponse
-	err = json.Unmarshal(res, &r)
-	if err != nil {
-		return PagesDeploymentStageLogs{}, fmt.Errorf("%s: %w", errUnmarshalError, err)
-	}
-	return r.Result, nil
-}
-
-// GetPagesDeploymentStageLogs returns the logs for a Pages deployment stage.
+// GetPagesDeploymentLogs returns the logs for a Pages deployment.
 //
 // API reference: https://api.cloudflare.com/#pages-deployment-get-deployment-logs
 func (api *API) GetPagesDeploymentLogs(ctx context.Context, rc *ResourceContainer, params GetPagesDeploymentLogsParams) (PagesDeploymentLogs, error) {

pages_deployment_test.go

@@ -411,35 +411,6 @@ func TestGetPagesDeploymentInfo(t *testing.T) {
 	}
 }
 
-func TestGetPagesDeploymentStageLogs(t *testing.T) {
-	setup()
-	defer teardown()
-
-	handler := func(w http.ResponseWriter, r *http.Request) {
-		assert.Equal(t, http.MethodGet, r.Method, "Expected method 'GET', got %s", r.Method)
-
-		w.Header().Set("content-type", "application/json")
-		fmt.Fprintf(w, `{
-			"success": true,
-			"errors": [],
-			"messages": [],
-			"result": %s
-		}`, testPagesDeploymentStageLogsResponse)
-	}
-
-	mux.HandleFunc("/accounts/"+testAccountID+"/pages/projects/test/deployments/0012e50b-fa5d-44db-8cb5-1f372785dcbe/history/build/logs", handler)
-
-	actual, err := client.GetPagesDeploymentStageLogs(context.Background(), AccountIdentifier(testAccountID), GetPagesDeploymentStageLogsParams{
-		ProjectName:  "test",
-		DeploymentID: "0012e50b-fa5d-44db-8cb5-1f372785dcbe",
-		StageName:    "build",
-		SizeOptions:  SizeOptions{},
-	})
-	if assert.NoError(t, err) {
-		assert.Equal(t, *expectedPagesDeploymentStageLogs, actual)
-	}
-}
-
 func TestGetPagesDeploymentLogs(t *testing.T) {
 	setup()
 	defer teardown()

pages_domain.go

@@ -44,8 +44,8 @@ type PagesDomainsResponse struct {
 
 // PagesDomainParameters represents parameters for a pages domain request.
 type PagesDomainParameters struct {
-	AccountID   string
-	ProjectName string
+	AccountID   string `json:"-"`
+	ProjectName string `json:"-"`
 	DomainName  string `json:"name,omitempty"`
 }