[D1] feat: add missing d1 meta object properties
#14422
Conversation
hrueger
requested review from
elithrar,
rozenmd,
vy-ton,
joshthoward,
Maddy-Cloudflare and
a team
as code owners
github-actions
bot
added
size/xs
product:d1
| changes: number, // the number of data rows (excluding extra indices) changed by this query | ||
| changed_db: boolean, // whether the db was changed by this query | ||
| size_after: number, // the db size after executing this query | ||
| last_row_id: number // ToDo |
There was a problem hiding this comment.
@joshthoward user facing description for this field?
There was a problem hiding this comment.
meta has type Record<string, unknown>. We shouldn't strongly type this in the docs.
There was a problem hiding this comment.
Hm. Is that expected to change frequently or what is the reason for it to be Record<string, unknown>? Big projects like prisma use it...
There was a problem hiding this comment.
@hrueger we wouldn't change existing fields from the response without gating the change behind a compatibility date. I want to keep our documentation and Typescript types in sync.
There was a problem hiding this comment.
That all makes perfect sense. Can I make a PR to update the types first, and after that this PR can be considered?
There was a problem hiding this comment.
Updating the types is still a breaking change.
Maddy-Cloudflare
changed the title
meta object propertiesmeta object properties
Hi,
this adds docs about the missing properties to the
metaobject returned bystmt.all()anddb.batch()d1 methods.I'm not sure what
last_row_idis exactly, can anyone help with that?I think the information added here has quite some value - I did make a pretty weird pr to another project because I did not know how to get the number of changed rows excluding indices (since there were no docs on that). Turns out - it's pretty simple 馃槄
Thanks for looking into this!