Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tss/rsa: Fixes RSA signature size. #395

Merged
merged 1 commit into from Jan 27, 2023
Merged

tss/rsa: Fixes RSA signature size. #395

merged 1 commit into from Jan 27, 2023

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Jan 26, 2023

As per RFC 8017 Section 8.2.2

If the length of the signature S is not k octets (where k is the length in octets of the RSA modulus n), output "invalid signature" and stop.

@armfazh armfazh added the fix-A-bug code that fix a bug label Jan 26, 2023
@armfazh armfazh self-assigned this Jan 26, 2023
@armfazh armfazh merged commit fa6e0cc into cloudflare:main Jan 27, 2023
@armfazh armfazh deleted the fixRSATssSignature branch January 27, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanyav2 tanyav2 tanyav2 approved these changes

@bwesterb bwesterb Awaiting requested review from bwesterb

Assignees

@armfazh armfazh

Labels
fix-A-bug code that fix a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@armfazh @tanyav2