fix http result errors by wrapping the upstream error, allowing for isNack #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Greene <stephen.greene@sap.com>
…sNack Signed-off-by: Scott Nichols <n3wscott@chainguard.dev>
|
@sbgreene1307 would you mind reviewing this? Thanks for your unit test and your issue!! |
n3wscott
commented
Mar 24, 2022
n3wscott
force-pushed
the
sbgreene-762-proto-result-nonnack
branch
from
a43e5cb
to
55e88fc
Compare
n3wscott
commented
Mar 24, 2022
Signed-off-by: Scott Nichols <n3wscott@chainguard.dev>
n3wscott
force-pushed
the
sbgreene-762-proto-result-nonnack
branch
from
55e88fc
to
b060ffb
Compare
sbgreene1307
suggested changes
Mar 28, 2022
| @@ -113,6 +114,9 @@ func (t *tapHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
| w.WriteHeader(500) | |||
| return | |||
| } | |||
| if t.statusCode > 299 { | |||
| w.WriteHeader(t.statusCode) | |||
There was a problem hiding this comment.
I forgot to add a return here which I think is what is causing the "superfluous" log line that you see in the tests. Do you want to just add that?
| @@ -83,6 +86,7 @@ func ClientDirect(t *testing.T, tc DirectTapTest, copts ...client.Option) { | |||
| t.Errorf("expected ACK, got %s", result) | |||
| } | |||
| } else if !cloudevents.ResultIs(result, tc.wantResult) { | |||
| t.Errorf("result.IsUndelivered = %v", cloudevents.IsUndelivered(result)) | |||
There was a problem hiding this comment.
This can be removed now as well
There was a problem hiding this comment.
I don't mind the extra output
n3wscott
commented
Mar 31, 2022
Signed-off-by: Scott Nichols <n3wscott@chainguard.dev>
n3wscott
force-pushed
the
sbgreene-762-proto-result-nonnack
branch
from
ecbe51c
to
cfc6cef
Compare
…or before the handler Signed-off-by: Scott Nichols <n3wscott@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #762