vmm: Make gdb break/resuming more resilient #4363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also addresses the |
rbradford
force-pushed
the
2022-07-25-gdb-tweaks
branch
from
9d35c08
to
93fcc40
Compare
When starting the VM such that it is already on a breakpoint (via stop_on_boot) when attached to gdb then start the vCPUs in a paused state rather than starting the vCPUs later (upon resume). Further, make the resumption/break of the VM more resilient by only attempting to resume the vCPUs if were are already in a break point and only attempting to pause/break if we were already running. Fixes: cloud-hypervisor#4354 Signed-off-by: Rob Bradford <robert.bradford@intel.com>
rbradford
force-pushed
the
2022-07-25-gdb-tweaks
branch
from
93fcc40
to
cd041a0
Compare
likebreath
approved these changes
Jul 25, 2022
Signed-off-by: Rob Bradford <robert.bradford@intel.com>
|
I tested the code with the |
michael2012z
approved these changes
Jul 26, 2022
sboeuf
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting the VM such that it is already on a breakpoint (via
stop_on_boot) when attached to gdb then start the vCPUs in a paused
state rather than starting the vCPUs later (upon resume).
Further, make the resumption/break of the VM more resilient by only
attempting to resume the vCPUs if were are already in a break point and
only attempting to pause/break if we were already running.
Fixes: #4354
Signed-off-by: Rob Bradford robert.bradford@intel.com