Refactor AArch64 VCPU registers related code in hypervisor
#4298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael2012z
force-pushed
the
aarch64-refactor-regs
branch
from
ba6771a
to
f71006e
Compare
liuw
approved these changes
Jul 11, 2022
michael2012z
force-pushed
the
aarch64-refactor-regs
branch
from
f71006e
to
eeb6451
Compare
MrXinWang
approved these changes
Jul 12, 2022
russell-islam
approved these changes
Jul 13, 2022
rbradford
approved these changes
Jul 14, 2022
On AArch64, the function `core_registers` and `set_core_registers` are the same thing of `get/set_regs` on x86_64. Now the names are aligned. This will benefit supporting `gdb`. Signed-off-by: Michael Zhao <michael.zhao@arm.com>
Function `system_registers` took mutable vector reference and modified the vector content. Now change the definition to `get/set` style. And rename to `get/set_sys_regs` to align with other functions. Signed-off-by: Michael Zhao <michael.zhao@arm.com>
Some `arch_target = "arm"' usages on VCPU related code are not correct. And we don't support 32-bit ARM architecture. Signed-off-by: Michael Zhao <michael.zhao@arm.com>
michael2012z
force-pushed
the
aarch64-refactor-regs
branch
from
eeb6451
to
0ac5c84
Compare
MrXinWang
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the PR prepares for #3980
Refactor VCPU registers related code in
hypervisorcrate:(set_)core_registerstoget/set_regs, aligning to the equivalent functions on X86. Now we have following registers related functions:get/set_regs(X86_64 & AArch64): Access general purposed registersget/set_sregs(X86_64 only): Access special registersget/set_sys_regs(AArch64 only): Access some system registers. (Now this group of function can not be aligned toget/set_sregson X86_64, they are quite different.)(set_)system_registers.#[cfg(any(target_arch = "arm", target_arch = "aarch64"))]with#[cfg(target_arch = "aarch64")]. Because we do not supportarmnow; and some usages were not precise.