Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unspecify GitHub Actions' versions #1029

Conversation

Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@jihoon-seo jihoon-seo added the hold Need to hold merge label Feb 9, 2022
@jihoon-seo
Copy link
Member Author

jihoon-seo commented Feb 9, 2022

the `uses' attribute must be a path, a Docker image, or owner/repo@ref

아마 이것 때문일 것으로 추정됩니다 🤔

-uses: "pascalgn/automerge-action@v0.14.3"
+uses: "pascalgn/automerge-action"

uses: "pascalgn/automerge-action@v0" 은 안 될 것 같아서 저렇게 했는데..
v0 으로 해 봐야겠네요 🤔


act 로 로컬에서 테스트해보려고 했는데 안 되네요 🤔

❯ act issue_comment
ERRO[0000] Unable to interpolate string '${{ github.event.issue.pull_request && (contains('seokho-son jihoon-seo hermitkim1', github.event.comment.user.login) || github.event.comment.author_association == 'OWNER') && startsWith(github.event.comment.body, '/approve') }}' - [TypeError: Cannot access member 'pull_request' of undefined] 
ERRO[0000] Unable to interpolate string '${{ github.event.comment.author_association == 'OWNER' || github.event.comment.author_association == 'MEMBER' }}' - [TypeError: Cannot access member 'author_association' of undefined]
❯ act -j automerge
ERRO[0000] Unable to interpolate string '${{ github.event.issue.pull_request && (contains('seokho-son jihoon-seo hermitkim1', github.event.comment.user.login) || github.event.comment.author_association == 'OWNER') && startsWith(github.event.comment.body, '/approve') }}' - [TypeError: Cannot access member 'pull_request' of undefined]
❯ act -j automerge -s github.event.issue.pull_request=1
ERRO[0000] Unable to interpolate string '${{ github.event.issue.pull_request && (contains('seokho-son jihoon-seo hermitkim1', github.event.comment.user.login) || github.event.comment.author_association == 'OWNER') && startsWith(github.event.comment.body, '/approve') }}' - [TypeError: Cannot access member 'pull_request' of undefined] 
❯ act -j automerge -s pull_request=1 
ERRO[0000] Unable to interpolate string '${{ github.event.issue.pull_request && (contains('seokho-son jihoon-seo hermitkim1', github.event.comment.user.login) || github.event.comment.author_association == 'OWNER') && startsWith(github.event.comment.body, '/approve') }}' - [TypeError: Cannot access member 'pull_request' of undefined] 

@jihoon-seo jihoon-seo force-pushed the 220209_Unspecify_GitHub_Actions_versions branch from 6555717 to 3dd4990 Compare February 9, 2022 04:27
@jihoon-seo jihoon-seo removed the hold Need to hold merge label Feb 9, 2022
@jihoon-seo
Copy link
Member Author

force-push: 이렇게 변경했습니다.

-uses: "pascalgn/automerge-action@v0.14.3"
+uses: "pascalgn/automerge-action@v0"

그런데 https://github.com/jihoon-seo/cb-tumblebug/actions/runs/1815883832 여기에
"Re-run all jobs" 버튼이 없어서 merge 전 테스트를 해 볼 수가 없네요 😢

https://github.com/jihoon-seo/cb-tumblebug/actions/runs/1815883832
image


https://github.com/jihoon-seo/cb-tumblebug/actions/runs/1786848946
image


https://github.com/jihoon-seo/cb-tumblebug/actions/workflows/auto-merge.yml
image


@seokho-son
Copy link
Member

감사합니다. 일단 머지하고 확인해봐도 될거 같습니다!^^

@seokho-son seokho-son merged commit 8895c9c into cloud-barista:main Feb 9, 2022
@jihoon-seo jihoon-seo deleted the 220209_Unspecify_GitHub_Actions_versions branch February 9, 2022 04:44
@jihoon-seo
Copy link
Member Author

확인해 보니
현재 cb/tb repo에서는
해당 workflow가 disable 되어 있네요 😊

https://github.com/cloud-barista/cb-tumblebug/actions/workflows/auto-merge.yml
image

@jihoon-seo
Copy link
Member Author

다른 GitHub Action에 대해 에러가 발생했습니다. 😢

https://github.com/cloud-barista/cb-tumblebug/actions/runs/1816211953

Unable to resolve action jpmcb/prow-github-actions@v1, unable to find version v1

그런데, 해당 GitHub Action repo에 가 보면
예제에 @v1 만 기재되어 있습니다. (즉, 작동한다는 뜻일텐데..)
이상하네요.. 🤔

    steps:
      - uses: jpmcb/prow-github-actions@v1

@seokho-son
Copy link
Member

@jihoon-seo 음.. actions 중에 breaking update를 마이너 버전에서 하는 경우들이 있어서 그렇지 않을까요?
개인이 만든 action의 경우 문서화가 명확하게 되어 있지 않은 경우도 좀 있습니다.
그 관점에서는 일부 action은 동작하는 버전 (우리가 확인한) 을 명시해줄 필요도 있겠습니다. (아마도)

@jihoon-seo jihoon-seo mentioned this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unspecify GitHub Actions' version
2 participants