Remove 'cache_location' option, since sassc doesn't use it

It's not in the Ruby gem and it's also not in libsass. See: sass/libsass#2879
cllns · Jul 26, 2019 · 5b72f02 · 5b72f02
1 parent 7d75c62
commit 5b72f02
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 24 deletions.
diff --git a/lib/hanami/assets/compilers/sass.rb b/lib/hanami/assets/compilers/sass.rb
@@ -10,11 +10,6 @@ class Sass < Compiler
         # @api private
         EXTENSIONS = /\.(sass|scss)\z/.freeze
 
-        # @since 0.1.0
-        # @api private
-        CACHE_LOCATION = Pathname(Hanami.respond_to?(:root) ? # rubocop:disable Style/MultilineTernaryOperator
-                                  Hanami.root : Dir.pwd).join('tmp', 'sass-cache')
-
         # @since 0.3.0
         # @api private
         def self.eligible?(name)
@@ -26,7 +21,7 @@ def self.eligible?(name)
         # @since 0.3.0
         # @api private
         def renderer
-          Tilt.new(source, nil, load_paths: load_paths, cache_location: CACHE_LOCATION)
+          Tilt.new(source, nil, load_paths: load_paths)
         end
 
         # @since 0.3.0
@@ -43,7 +38,6 @@ def engine
           ::SassC::Engine.new(
             to_be_compiled,
             load_paths: load_paths,
-            cache_location: CACHE_LOCATION,
             syntax: (:sass if ::File.extname(source.to_s) == ".sass")
           )
         end

diff --git a/lib/hanami/assets/compressors/sass_stylesheet.rb b/lib/hanami/assets/compressors/sass_stylesheet.rb
@@ -6,7 +6,7 @@ module Assets
     module Compressors
       # Sass compressor for stylesheet
       #
-      # It depends on <tt>sass</tt> gem.
+      # It depends on <tt>sassc</tt> gem.
       #
       # @since 0.1.0
       # @api private
@@ -16,12 +16,6 @@ module Compressors
       class SassStylesheet < Stylesheet
         # @since 0.1.0
         # @api private
-        #
-        # FIXME This is the same logic that we have for Hanami::Assets::Compiler
-        SASS_CACHE_LOCATION = Pathname(Hanami.respond_to?(:root) ? # rubocop:disable Style/MultilineTernaryOperator
-                                       Hanami.root : Dir.pwd).join('tmp', 'sass-cache')
-        # @since 0.1.0
-        # @api private
         def initialize
           @compressor = SassC::Engine
         end
@@ -30,7 +24,7 @@ def initialize
         # @api private
         def compress(filename)
           compressor.new(read(filename), filename: filename, syntax: :scss,
-                                         style: :compressed, cache_location: SASS_CACHE_LOCATION).render
+                                         style: :compressed).render
         end
       end
     end

diff --git a/spec/integration/hanami/assets/compiler_spec.rb b/spec/integration/hanami/assets/compiler_spec.rb
@@ -208,15 +208,6 @@
     expect(target.read).to match %(body {\n  font: 100% Helvetica, sans-serif;\n  color: #fff; }\n)
   end
 
-  it 'uses defined sass cache directory' do
-    directory = Pathname.new(Dir.pwd).join('tmp', 'sass-cache')
-    directory.rmtree if directory.exist?
-
-    Hanami::Assets::Compiler.compile(@config, 'compile-sass.css')
-
-    expect(directory.exist?).to eq(true)
-  end
-
   it 'compiles scss asset if direct dependency has changed' do
     dependency = TestFile.new(path: '_background.scss') do
       write 'body { background-color: purple; }'