Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NODE_PATH for legacy projects #235

Merged
merged 8 commits into from Apr 25, 2019
Merged

Fix NODE_PATH for legacy projects #235

merged 8 commits into from Apr 25, 2019

Commits on Apr 11, 2019

  1. Seems this doesn't matter anymore 

    clinicjs#132

But ths still relates to current state
clinicjs/node-clinic#148

So there might be changes done to fix NODE_PATH back, for legacy projects.
    @wentout
    wentout committed Apr 11, 2019
    Copy the full SHA
    860458a View commit details
    Browse the repository at this point in the history

  2. fix CI comma & occasionally replaced logger path

    @wentout
    wentout committed Apr 11, 2019
    Copy the full SHA
    cfd5589 View commit details
    Browse the repository at this point in the history

  3. onliner for makeInjectPath

    @wentout
    wentout committed Apr 11, 2019
    Copy the full SHA
    ee226c3 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2019

  1. Additional Fix after code-review. 

    Thanks to @goto-bus-stop !
NODE_PATH works from both prospects.
    @wentout
    wentout committed Apr 23, 2019
    Copy the full SHA
    c4e9c49 View commit details
    Browse the repository at this point in the history

  2. Finally got rid of broken parts.

    @wentout
    wentout committed Apr 23, 2019
    Copy the full SHA
    3ff566f View commit details
    Browse the repository at this point in the history

  3. investigation checks issues

    @wentout
    wentout committed Apr 23, 2019
    Copy the full SHA
    f467236 View commit details
    Browse the repository at this point in the history

  4. investigation checks issues 2

    @wentout
    wentout committed Apr 23, 2019
    Copy the full SHA
    e34ecd3 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2019

  1. reverting changes for the test

    @wentout
    wentout committed Apr 25, 2019
    Copy the full SHA
    51765a0 View commit details
    Browse the repository at this point in the history