Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update reflections from v0.9.12 to v0.10.2 #79

Merged
merged 1 commit into from Apr 23, 2023

Conversation

theborakompanioni
Copy link
Collaborator

This PR updated dependency org.reflections:reflections from v0.9.12 to v0.10.2

Ran in to the following issue: ronmamo/reflections#297
This seems to have been fixed with newer version (>=v0.10.0) of org.reflections:reflections.

Caused by: org.reflections.ReflectionsException: Scanner FieldAnnotationsScanner was not configured
	at org.reflections.Store.get(Store.java:39)
	at org.reflections.Store.get(Store.java:61)
	at org.reflections.Store.get(Store.java:46)
	at org.reflections.Reflections.getFieldsAnnotatedWith(Reflections.java:546)
	at jrpc.clightning.plugins.CLightningPlugin.addOptionsWithAnnotation(CLightningPlugin.java:305)
	at jrpc.clightning.plugins.CLightningPlugin.registerMethod(CLightningPlugin.java:298)
	at jrpc.clightning.plugins.CLightningPlugin.start(CLightningPlugin.java:115)
	at org.tbk.example.ExamplePlugin.start(ExamplePlugin.java:14)

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (ad020c0) 41.52% compared to head (591e7fe) 41.52%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #79   +/-   ##
=========================================
  Coverage     41.52%   41.52%           
  Complexity      332      332           
=========================================
  Files           128      128           
  Lines          2129     2129           
  Branches        149      149           
=========================================
  Hits            884      884           
  Misses         1154     1154           
  Partials         91       91           
Flag Coverage Δ
unittests 41.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 591e7fe

@vincenzopalazzo vincenzopalazzo merged commit 53b8ec1 into clightning4j:master Apr 23, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants