Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Google "OAuth 2.0 for TV and Limited-Input Device Applications" #24

Merged
merged 3 commits into from Dec 16, 2022
Merged

Support Google "OAuth 2.0 for TV and Limited-Input Device Applications" #24

merged 3 commits into from Dec 16, 2022

Conversation

markandrus
Copy link
Contributor

@markandrus markandrus commented Mar 26, 2022

With some minor changes, this library can be made to work with Google's "OAuth 2.0 for TV and Limited-Input Device Applications". There are just two small changes to make:

  • Google returns a verification_url instead of verification_uri, and
  • Google requires the client_secret when polling for tokens.

Example authentication

Copy code: QCP-GZV-LGZ
then open: https://www.google.com/device
Access token: $ACCESS_TOKEN

Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've pushed changes to restore backwards compatibility with PollToken and introduce new PollTokenWithOptions.

@mislav mislav merged commit f564fe4 into cli:main Dec 16, 2022
@markandrus markandrus deleted the support-google branch December 22, 2022 17:44
@markandrus
Copy link
Contributor Author

Thanks, @mislav! I overlooked that I broke compatibility for PollToken, thanks for fixing it 🙌 — and I can get rid of my private fork now, woohoo 🕺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants