Support third-party OAuth hosts #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My original intention wasn't for this to be backwards-compatible, but looking back now its absolutely achievable - so I'll make an update to handle that.
No. GitHub's server implementation is non-standard and responds with I did make a start on this effort locally, with my original intent being to submit a second pr - those changes make sense under this pr, so I may just finish that up and push it here :) |
|
I will look at the tests in a bit, but I've verified that the changes now support Microsoft's endpoints :) Would you be interested in adding something like // ServerAzure gets a Server for the given Azure Active Directory tenant. If tenant is
// empty, it will default to "common".
//
// See https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-device-code
func ServerAzure(tenant string) *Server {
if tenant == "" {
tenant = "common"
}
return &Server{
DeviceCodeURL: fmt.Sprintf("https://login.microsoftonline.com/%s/oauth2/v2.0/devicecode", tenant),
AuthorizeURL: fmt.Sprintf("https://login.microsoftonline.com/%s/oauth2/v2.0/authorize", tenant),
TokenURL: fmt.Sprintf("https://login.microsoftonline.com/%s/oauth2/v2.0/token", tenant),
}
} |
jamierocks
force-pushed
the
server
branch
2 times, most recently
from
7d51c27
to
ec550ca
Compare
jamierocks
changed the title
slowturtle88
approved these changes
May 9, 2021
ghost
approved these changes
Aug 3, 2021
api/access_token_test.go
Outdated
| values: map[string]string{ | ||
| "access_token": "ATOKEN", | ||
| "token_type": "bearer", | ||
| "scope": "repo gist", | ||
| }, | ||
| }, | ||
| want: &AccessToken{ |
ghost
approved these changes
Aug 4, 2021
ghost
reviewed
Aug 4, 2021
api/form_test.go
Outdated
| @@ -173,7 +173,7 @@ func TestPostForm(t *testing.T) { | |||
| want: &FormResponse{ | |||
| StatusCode: 502, | |||
| requestURI: "https://github.com/oauth", | |||
| values: url.Values(nil), | |||
| values: make(map[string]string), | |||
| }, | |||
| wantErr: false, | |||
| }, | |||
ghost
approved these changes
Aug 4, 2021
ghost
approved these changes
Aug 4, 2021
ghost
approved these changes
Aug 4, 2021
server.go
Outdated
| AuthorizeURL: fmt.Sprintf("https://%s/login/oauth/authorize", host), | ||
| TokenURL: fmt.Sprintf("https://%s/login/oauth/access_token", host), | ||
| } | ||
| } |
Not all OAuth hosts use the same routes as GitHub, for example: - Microsoft use /oauth2/v2.0/devicecode - Google use /device/code - Auth0 use /oauth/device/code Similar differences are present for the authorise and access token routes too. This commit introduces a concept of a Host, which is a container for the endpoints that the library uses. After this, the Hostname field is deprecated. Co-authored-by: Mislav Marohnić <mislav@github.com>
Co-authored-by: Mislav Marohnić <mislav@github.com>
mislav
approved these changes
Oct 15, 2021
tonymreyes537
pushed a commit
to tonymreyes537/oauth
that referenced
this pull request
Dec 31, 2021
Support third-party OAuth hosts Signed-off-by: antonio de jesus medina <tonymreyes537@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should make some headway to supporting further OAuth providers than just GitHub. This pull request doesn't introduce specific support for anything, but provides an API to allow third-parties to their flavour endpoints.
Not all OAuth hosts use the same routes as GitHub, for example:
Similar differences are present for the authorise and access token
routes too.
This commit introduces a concept of a Server, which is a container for
the endpoints that the library uses. This is a replacement for Flow's
Hostname and as such is a breaking change.