Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Interest in adding support for the Microsoft identity platform's OAuth device flow? #10

Closed
swinton opened this issue Jul 14, 2021 · 3 comments

Comments

@swinton
Copy link
Contributor

swinton commented Jul 14, 2021

Hey there! Thanks for making this oauth module, it's awesome!

Curious if there is interest in adding support for the Microsoft identity platform's OAuth device flow?

I took a quick look at what's needed, and I think potentially the "only" change would be to support a JSON response from the device code endpoint, currently it looks like we only handle form responses:

const formType = "application/x-www-form-urlencoded"

I think if it could accept JSON, then other OAuth servers, like Microsoft identity platform's, would come for free.

Thoughts?

@mislav
Copy link
Contributor

mislav commented Aug 3, 2021

@swinton I think that would be a great addition! Thanks for your patience waiting for my reply— I was away some of that time on vacation.

Could you look at our open PRs and check if any address the functionality needed for what you're describing, or should it be a new PR?

@swinton
Copy link
Contributor Author

swinton commented Aug 3, 2021

Thanks @mislav ...

Could you look at our open PRs and check if any address the functionality needed for what you're describing, or should it be a new PR?

Actually, #7 looks promising 👍

@mislav
Copy link
Contributor

mislav commented Dec 16, 2022

Closing as the referenced PR got merged and JSON support got added.

@mislav mislav closed this as completed Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants