jq: add option to pretty print JSON output #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
suggested changes
Apr 3, 2023
mislav
reviewed
Apr 3, 2023
Adds a new function `EvaluateFormatted` to maintain backward compatibility; colorizing is handled by pkg/jsonpretty in this repository.
mjpieters
force-pushed
the
jq_pretty_print
branch
from
d3a4294
to
ffc3dcc
Compare
|
@mislav: thanks for the update there, it shows how green I am around my GoLang ears here. |
|
No worries and you're welcome. Your solution wasn't perfectly fine. My approach ins't necessarily less code but I think it might be easier to read and comprehend. |
Well, I care a lot about readability, and the whole encoder setup was not giving me the 'this code just fits' feeling yet. I like the approach you took because that is a lot more readable. I've made note, so thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new function
EvaluateFormattedto maintain backward compatibility.Indenting output by 2 spaces matches jq output.
Needed for cli/cli#3994