Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match hostnames case-insensitively #105

Closed
wants to merge 3 commits into from
Closed

Match hostnames case-insensitively #105

wants to merge 3 commits into from

Conversation

mislav
Copy link
Contributor

@mislav mislav commented Feb 16, 2023

TODO:

  • check if the change to FindEntry will affect alias resolution?

@mislav
WIP: match hostnames case-insensitively
fc01505 
TODO:
- check if this will affect alias resolution
@mislav mislav mentioned this pull request Feb 17, 2023
Merged
@mislav
Copy link
Contributor Author

mislav commented Apr 17, 2023

To avoid affecting case-sensitive alias resolution, I ideally wanted to perform case-insensitive lookups only for keys under hosts, but doing so required more changes to the implementation I was comfortable with, and the overall approach still feels brittle. Shelving this for now and making a simple workaround in the cli/cli repo.

@mislav mislav closed this Apr 17, 2023
@mislav mislav deleted the case-insensitive-hostnames branch April 17, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mislav