Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for garage.github.com #6478

Merged
merged 2 commits into from Nov 3, 2022
Merged

Add support for garage.github.com #6478

merged 2 commits into from Nov 3, 2022

Conversation

mislav
Copy link
Contributor

@mislav mislav commented Oct 21, 2022

The other part of this is in cli/go-gh#85

@mislav mislav requested a review from a team as a code owner October 21, 2022 11:52
@mislav mislav requested review from vilmibm and removed request for a team October 21, 2022 11:52
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Oct 21, 2022
samcoe
samcoe approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Perhaps a test or two would make sense.

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Oct 31, 2022
@mislav mislav enabled auto-merge (squash) November 3, 2022 11:58
@mislav mislav merged commit b94d073 into trunk Nov 3, 2022
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Nov 3, 2022
@mislav mislav deleted the garage branch November 3, 2022 12:12
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcoe samcoe samcoe approved these changes

@vilmibm vilmibm Awaiting requested review from vilmibm vilmibm is a code owner automatically assigned from cli/code-reviewers

Assignees

@mislav mislav

Labels
None yet
Projects
No open projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mislav @samcoe