Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/spf13/cobra from v1.4.0 to v1.5.0 #6196

Merged
merged 1 commit into from Sep 6, 2022

Conversation

anthonyfok
Copy link
Contributor

@anthonyfok anthonyfok commented Sep 5, 2022

Cobra v1.5.0 contains a fix for the zsh autocompletion #compdef line to only complete <command>, not _<command> (the completion function itself), see spf13/cobra#1690

TestNewCmdCompletion for zsh is updated accordingly.


Thanks to @zhsj for discovering the FTBFS (fail to build from source) bug in Debian where golang-github-spf13-cobra-dev was updated to 1.5.0 some time ago, see https://bugs.debian.org/1019137

Cobra v1.5.0 contains a fix for the zsh autocompletion #compdef line
to only complete <command>, not _<command> (the completion function
itself), see spf13/cobra#1690

TestNewCmdCompletion for zsh is updated accordingly.
@anthonyfok anthonyfok requested a review from a team as a code owner September 5, 2022 09:03
@anthonyfok anthonyfok requested review from vilmibm and removed request for a team September 5, 2022 09:03
@cliAutomation
Copy link
Collaborator

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Sep 5, 2022
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Sep 5, 2022
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Sep 5, 2022
@samcoe samcoe merged commit c219579 into cli:trunk Sep 6, 2022
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Sep 6, 2022
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external pull request originating outside of the CLI core team
Projects
No open projects
The GitHub CLI
  
Done 💤
Development

Successfully merging this pull request may close these issues.

None yet

4 participants