Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Cobra for improved shell completion support #4028

Merged
merged 5 commits into from Jul 27, 2021
Merged

Upgrade Cobra for improved shell completion support #4028

merged 5 commits into from Jul 27, 2021

Commits on Jul 21, 2021

  1. Bump Cobra for improved completion support

    @mislav
    mislav committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    3e8f075 View commit details
    Browse the repository at this point in the history

  2. Allow space to be added after completing issue/pr list --state values 

    The "nospace" directive instructs the shell completion logic to avoid
adding a space after completing the word. However, this feature was
broken in an older Cobra, and users still saw a space character added.
In most case we want the space because we anticipate that the user might
want to add extra arguments to the command.
    @mislav
    mislav committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    db8204d View commit details
    Browse the repository at this point in the history

  3. Allow shell-completing multiple --json fields separated by commas

    @mislav
    mislav committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    4d7625c View commit details
    Browse the repository at this point in the history

  4. Add completion support to repo create --gitignore and --license

    @mislav
    mislav committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    6ed2e8f View commit details
    Browse the repository at this point in the history

  5. Switch to Cobra's bash completion V2

    @mislav
    mislav committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    2801206 View commit details
    Browse the repository at this point in the history