Remove square brackets from persistent flag description to fix zsh autocomplete

[samcoe]

Summary

closes #1703

Details

The square brackets in repo PersistentFlags description is causing ZSH autocomplete to break. Cobra should be escaping them properly when generating the autocomplete file but that seems to be broken. Temporarily removing [HOST/] until we come up with a more permanent solution.

Looks like this issue will be fixed with the next release of Cobra spf13/cobra#1070

[cristiand391]

I was about to open an issue about this.

Cobra has already solved this bug but we will need to bump it up to this specific commit or wait until the next release.
I tried the new zsh completion on my machine and it escapes square brackets succesfully without any change.

This new implementation brings some behavioral changes, the most important I think is file completion by default which we could gradually disable after updating Cobra.

I think custom completion could bring some interesting functionality to commands like gh pr view [tab][tab], is there any interest in updating Cobra?

[mislav]

@cristiand391 Thanks for looking into all that! At the moment we will avoid upgrading Cobra, but you are welcome to do an exploration of what we could do with completions in a newer version! For example, if gh pr view [Tab][Tab] could show the list of PRs to view, that would be excellent. Please send us a PR if you end up with something 🙇

[mislav]

Thank you!

[toby-griffiths]

Please can anyone advise when can we expect this to be released?