fix(clerk-react): Add frontendAPI on window as a fallback #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store frontendAPI value on window as a fallback. This value can be used as a fallback during ClerkJS hot loading in case ClerkJS fails to find the "data-clerk-frontend-api" attribute on its script tag. This can happen when the DOM is altered completely during client rehydration. For example, in Remix with React 18 the document changes completely via `hydrateRoot(document)`. For more information refer to: - remix-run/remix#2947 - facebook/react#24430
SokratisVidros
requested review from
nikosdouvlis,
anagstef,
raptisj,
colinclerk and
desiprisg
raptisj
approved these changes
Nov 2, 2022
anagstef
approved these changes
Nov 2, 2022
nikosdouvlis
approved these changes
Nov 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/clerk-expo@clerk/backend-core@clerk/clerk-sdk-node@clerk/edgebuild/tooling/choreDescription
npm testruns as expected.npm run buildruns as expected.Store frontendAPI value on window as a fallback. This value can be used as a fallback during ClerkJS hot loading in case ClerkJS fails to find the "data-clerk-frontend-api" attribute on its script tag.
This can happen when the DOM is altered completely during client rehydration. For example, in Remix with React 18 the document changes completely via
hydrateRoot(document).For more information refer to: