Issue #364 - dangling tooltips

[storrisi]

Fixes #364

Seems like this is a knows issue of ant-design when there is a Tooltip on a disabled Button, as explained here: ant-design/ant-design#9581

I've tried to replace the Tooltip with the Bootstrap one, but it doesn't work on elements that are not buttons, like a DropDown for example.

As a solution, i've hidden the tooltip if a disabled prop is passed to the render component.

[dabutvin]

I think this is a nice workaround for the issue!

Can we read the disabled property of button or do we need a separate prop for this?

[jeffmcaffer]

don't think that we can use the disabled prop of the supplied button. In the general case the value fo the button prop may not be an instance of the Button component so may not have a disabled prop. For example, it might be a Button wrapped in some other component (e.g., a Dropzone). So button would be an instance of Dropzone.

[jeffmcaffer]

I am curious why the Bootstrap tooltip does not work. I'm quite sure that we use it in many other places (on other sites) that are not buttons. While the workaround is ok, it feels unsustainable to pass duplicate disabled props everywhere that we use tooltips.

[storrisi]

Actually, i'm not so happy about this workaround as well.
I will investigate on the Bootstrap behaviour in order to find a different and more consistent solution.

[storrisi]

I've found what was the issue with Bootstrap, so i've brought it back to the implementation of Tooltips.
Additionally, i've changed the button property to more understandable children.
Of course this means that instead of passing a button prop to the component, it will render any kind of child of himself.

[jeffmcaffer]

@storrisi I am getting an error in ButtonWithTooltip when loading the defintiions page. It seems that children is coming in undefined. Was this working for you? Note that I did merge in the latest of master here. I'll continue to look but wanted to check. Perhaps my merge was bad

React.Children.only expected to receive a single React element child.

[storrisi]

It's probably because of the merge of the #375 , i'm gonna update this one since something has changed

[storrisi]

@jeffmcaffer fixed, now it should be fine, thanks for catching up