Upgrade to latest version of coverage #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
coverage==6.4 has been released, so we can merge this now. |
|
Oops, turns out that coverage 6.x dropped support for Python 3.6, so we need to think about how to handle that. We probably want to continue supporting 3.6, so maybe we stick with the old version of coverage for now? |
The issue that was introduced in coverage 6.3 has been fixed: nedbat/coveragepy#1310 (comment). We can't just upgrade to `coverage` or `coverage>=6.4` because the former could install bad versions of coverage (e.g. 6.3), and the latter is unsupported on Python 3.6, which we want to continue supporting. This patch just bans coverage 6.3 / 6.3.x, so with Python 3.7+, we'll use the latest version of coverage, and with Python 3.6, we'll use the latest supported version of coverage that's not a 6.3 release.
anishathalye
force-pushed
the
coverage-6.4
branch
from
c8a9578
to
b35085b
Compare
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
=======================================
Coverage 96.79% 96.79%
=======================================
Files 12 12
Lines 905 905
Branches 167 167
=======================================
Hits 876 876
Misses 11 11
Partials 18 18 Continue to review full report at Codecov.
|
|
In working shape now, should be good to merge. |
anishathalye
changed the title
jwmueller
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with coverage==6.3 has been fixed: nedbat/coveragepy#1310 (comment).