Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban coverage==6.3 #109

Merged
merged 1 commit into from Feb 2, 2022
Merged

Conversation

anishathalye
Copy link
Member

See nedbat/coveragepy#1312. We can remove this once a newer version of coverage is released that includes nedbat/coveragepy@00da68e.

Competing PR: #108

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #109 (f71cb3b) into master (3fb5024) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   86.50%   86.50%           
=======================================
  Files          12       12           
  Lines         956      956           
  Branches      163      163           
=======================================
  Hits          827      827           
  Misses        115      115           
  Partials       14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fb5024...f71cb3b. Read the comment docs.

Copy link
Member

@jwmueller jwmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this simpler solution :)

See nedbat/coveragepy#1312. We can revert this
commit once a newer version of coverage fixes this issue.

coverage==6.3.1
(nedbat/coveragepy#1310 (comment))
doesn' t fully fix the issue either; hangs become less frequent but are
not eliminated (see e.g. this run of our tests with coverage==6.3.1:
https://github.com/cleanlab/cleanlab/runs/5036277812?check_suite_focus=true).
@anishathalye anishathalye merged commit f71cb3b into cleanlab:master Feb 2, 2022
@anishathalye anishathalye deleted the coverage-breakage branch April 7, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants